[INS-467] Add IPinfo detector to default detectors list#4970
Open
mustansir14 wants to merge 2 commits into
Open
[INS-467] Add IPinfo detector to default detectors list#4970mustansir14 wants to merge 2 commits into
mustansir14 wants to merge 2 commits into
Conversation
Corpora Test ResultsNo detector regex or keyword changes in this PR. Bench skipped. |
mustansir14
force-pushed
the
ins-467-add-ipinfo-detector-to-default-detectors
branch
from
cda3c7c to
d337d07
Compare
mustansir14
changed the base branch from
main
to
ins-465-add-datadogapikey-detector-to-defaults
kashifkhan0771
approved these changes
May 21, 2026
mustansir14
added
the
review/product-eng
shahzadhaider1
approved these changes
May 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
This PR adds the
IPinfodetector to the default detectors list. It also gates it behind a feature flag. It's based off of #4969 because that contains some plumbing that's needed here,Testing:
Unit Tests are passing. Integration tests didn't have the required keys in the GCP vault. Once added, they are passing too.
Corpora Testing:
The detector does not appear in the list.
Checklist:
make test-community)?make lintthis requires golangci-lint)?Note
Medium Risk
Medium risk because it changes the default detector set (and associated verification calls), which may affect scan performance and produce additional findings for existing users.
Overview
Adds the
IPinfodetector to the engine’s default detector list and gates it behind a newfeature.IPInfoDetectorEnabledflag that is enabled by default at startup.Updates default-detector coverage tests to treat
IPInfoas feature-flagged (no longer “missing by mistake”), and adjusts theipinfointegration test expectations to validate/ignore newly-populatedResultsecret-part fields.Reviewed by Cursor Bugbot for commit f449f74. Bugbot is set up for automated code reviews on this repo. Configure here.