update driver to work with the new gateway#267
Open
Gioee wants to merge 2 commits into
Open
Conversation
danielebriggi
requested changes
May 22, 2026
| /** Domain suffix that identifies the gateway environment. Appended to the tenant prefix | ||
| * (eg `crvheg7dhk.g4`) to form the gateway hostname the driver connects to. Default: | ||
| * `gateway.sqlite.cloud`. */ | ||
| gatewayurl?: string |
Member
There was a problem hiding this comment.
Domain suffix that identifies the gateway environment: rename the gatewayUrl instead of relying on comments.
The comment is not clear about the content of the variable.
| * when it already ends with the suffix (idempotent) or is too short to have a tenant prefix. */ | ||
| function buildGatewayHost(host: string, gatewayurl?: string): string { | ||
| if (!host) return host | ||
| const suffix = gatewayurl || 'gateway.sqlite.cloud' |
Member
There was a problem hiding this comment.
use a local constant variable
Comment on lines
+146
to
+148
| /** Builds the gateway hostname from a core hostname by replacing the last two labels with | ||
| * the given `gatewayurl` suffix (default `gateway.sqlite.cloud`). Returns host unchanged | ||
| * when it already ends with the suffix (idempotent) or is too short to have a tenant prefix. */ |
Member
There was a problem hiding this comment.
i admit that this comment is not clear. Just show what it does with an example. I don't know what's label is in the context of host, gatewayurl, buildGatewayUrl
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.