opentelemetry-instrumentation-botocore: capture Bedrock prompt cache token usage#4615
Open
vinigrazzioli-96 wants to merge 3 commits into
Open
Conversation
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Amazon Bedrock's Converse / ConverseStream APIs return
cacheReadInputTokensand
cacheWriteInputTokensin the responseusagewhen prompt caching isused. The botocore Bedrock instrumentation currently reads only
inputTokens/
outputTokens, so the cache token counts are dropped.This PR maps them to the OTel GenAI semantic-convention attributes (already
defined in
opentelemetry-semantic-conventions):cacheReadInputTokens→gen_ai.usage.cache_read.input_tokensChanges:
bedrock.py(_converse_on_success): set the cache token span attributesfor Converse / ConverseStream / InvokeModelWithResponseStream.
bedrock_utils.py(ConverseStreamWrapper): accumulate the cache tokencounts from the streaming
metadataevent into the response usage.Out of scope (possible follow-up): the non-streaming
InvokeModelClaudepath uses the native Anthropic
usageformat (cache_read_input_tokens/cache_creation_input_tokens, snake_case) and would need a separate change.Fixes #4614
Type of change
How Has This Been Tested?
test_converse_stream_accumulates_cache_tokens, a unit test thatfeeds a
metadataevent carrying cache token usage toConverseStreamWrapperand asserts the counts are accumulated.
tox -e py311-test-instrumentation-botocore-1-wrapt1— 134 passedtox -e lint-instrumentation-botocore— 10.00/10Checklist