Fix handler wrapping for keyword-only parameters#3084
Open
rohan-patnaik wants to merge 1 commit into
Open
Conversation
Author
|
@microsoft-github-policy-service agree |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3067
Summary
This fixes handler wrapping so keyword-only parameters are not counted as positional handler arguments.
Why
Before this change, a handler like
locator.blurwas treated as if it accepted the triggering locator because it has a keyword-onlytimeoutoption. Playwright then passed the locator positionally and crashed withTypeError.Test plan
python3 -m pytest tests/common/test_impl_to_api_mapping.pypython3 -m black --check playwright/_impl/_impl_to_api_mapping.py tests/common/test_impl_to_api_mapping.pypython3 -m mypy playwright/_impl/_impl_to_api_mapping.py