feat(binding): add per-request strict JSON binding (JSONStrict)#4642
Open
walle250ai wants to merge 1 commit into
Open
feat(binding): add per-request strict JSON binding (JSONStrict)#4642walle250ai wants to merge 1 commit into
walle250ai wants to merge 1 commit into
Conversation
…ejection Add jsonStrictBinding that always enables DisallowUnknownFields on the JSON decoder, independent of the global EnableDecoderDisallowUnknownFields flag. Exposes BindJSONStrict and ShouldBindJSONStrict on Context. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
Hi, Severity: action required | Category: correctness How to fix: Define JSONStrict for nomsgpack Agent prompt to fix - you can give this to your LLM of choice:
We noticed a couple of other issues in this PR as well - happy to share if helpful. Found by Qodo. Free code review for open-source maintainers. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The existing global flag is not safe for concurrent use: toggling it affects all in-flight requests, making per-endpoint strict validation impossible without race conditions.
This PR adds a request-scoped strict JSON binding path:
The existing behavior and are untouched.
Test plan
🤖 Generated with Claude Code