feat: add optional source_account to lambda permissions#87
Open
Rory Nolan (rorynolan) wants to merge 4 commits into
Open
feat: add optional source_account to lambda permissions#87Rory Nolan (rorynolan) wants to merge 4 commits into
Rory Nolan (rorynolan) wants to merge 4 commits into
Conversation
Rory Nolan (rorynolan)
requested review from
Joe Niland (joe-niland) and
RB (nitrocode)
|
/terratest |
yangci (oycyc)
previously approved these changes
Aug 3, 2025
yangci (oycyc)
left a comment
yangci (oycyc)
left a comment
There was a problem hiding this comment.
Good addition! As defined on the AWS provider docs as well: https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/lambda_permission#source_account-1
yangci (oycyc)
added
enhancement
|
Ugh seems like Terratest is failing because of the optional... Rory Nolan (@rorynolan) in your branch, can you try setting the examples/versions and where the required_version of TF to be >= 1.3.0 or >=1.4.0? |
auto-merge was automatically disabled
August 5, 2025 17:40
Head branch was pushed to by a user without write access
Author
|
yangci (@oycyc) I set it to minimum 1.4 can you please trigger a test rerun? |
|
/terratest |
- Make both source_arn and source_account optional in invoke_function_permissions - Add comprehensive documentation for all permission fields - Update complete example to demonstrate source_account usage - Maintain backward compatibility with existing configurations 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Rory Nolan (rorynolan)
force-pushed
the
main
branch
from
d896fae to
ba83c03
Compare
Author
|
yangci (@oycyc) I rebased onto updates can you please approve the test workflow again? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
what
why
Without this, you need to add custom stuff just to comply with the config rule lambda-function-public-access-prohibited, that requires
source_accountto be set.It should be easy to comply with this rule using the module natively.