feat(azure): accept pre-minted access tokens for federated identity /OIDC#2190
Open
jorgegmz wants to merge 1 commit into
Open
feat(azure): accept pre-minted access tokens for federated identity /OIDC#2190jorgegmz wants to merge 1 commit into
jorgegmz wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
CloudSploit currently authenticates to Azure via
ClientSecretCredentialonly —config.credentials.azure.application_id+key_valueare required by bothindex.js(config parsing) andhelpers/azure/auth.js(login()). Thisblocks adoption in environments where no client secret exists, most notably:
ClientAssertionCredentialrather than a static secret.These callers can mint the three audience-specific tokens that CloudSploit's plugins already consume, but there's currently no way to inject them.
Change
Strictly-additive support for a new
AccessTokensconfig field that accepts a pre-minted trio: