Simplify cloud environment dropdown when only one environment exists#2304
Draft
joshsny wants to merge 1 commit into
Draft
Simplify cloud environment dropdown when only one environment exists#2304joshsny wants to merge 1 commit into
joshsny wants to merge 1 commit into
Conversation
When the user has no custom sandbox environments, show a single 'Cloud' option inline with the other workspace modes instead of a separate 'Cloud environments' section with just the 'Default' entry. The full section with separator, header, and per-environment list is preserved when the user has created custom sandbox environments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When a user has only one cloud environment (the built-in Default), the workspace mode dropdown shows a "Cloud environments" section header with a single "Default" item underneath. This is confusing — "Cloud environment: default" doesn't clearly communicate what it means.
Changes
Modified
WorkspaceModeSelectto detect when there are no custom sandbox environments and render a simple "Cloud" option inline with the other workspace modes (Worktree, Local) instead of the full "Cloud environments" section.How did you test this?
Verified the component typechecks and that the lint-staged pre-commit hooks pass. No existing tests for this component.
Publish to changelog?
no
Slack Thread